Home work 4#12
Open
ARKUSNET wants to merge 16 commits intosh-vasily:mainfrom
Open
Conversation
# Conflicts: # basics/src/main/java/ru/msu/vmk/NumberSample.java
Home work 1 2
Change code by recommendation
Home work 4
Home work 4
sh-vasily
reviewed
Mar 19, 2024
| @Override | ||
| public Book getBookByTitle(String title) throws SQLException { | ||
| Book out = null; | ||
| String sql = "select * from LIBRARY.BOOK where title = ?"; |
Owner
There was a problem hiding this comment.
запросы со звездочкой в коде программы лучше не писать, нужно явно писать нужные столбцы
здесь не критично, но представьте, у вас со временем в новых версиях приложения может меняться схема данных, могут добавляться столбцы, их может быть достаточно много, что может привести к проблемам с производительностью
sh-vasily
reviewed
Mar 19, 2024
| Library library = new LibraryImpl("jdbc:derby:memory:testdb;create=true", "test", "test"); | ||
| library.init(); | ||
|
|
||
| NetworkServerControl nsc = new NetworkServerControl(InetAddress.getByName("localhost"), 1527); |
Author
There was a problem hiding this comment.
Забыл удалить. Искал способы как можно клиентом подключиться к Derby, чтобы данные в реальном времени смотреть, так и не нашел. Для IBM H2 проблем нет подключиться клиентом)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.